Repository navigation
fix(IEC-101): one-owner TX/RX evidence, bounded link state and safe Event Trace fallback - #199
Merged
Merged
Conversation
…al RX in timeline
…ers, dual links and bounded state
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
Comment on lines
+58
to
+66
| foreach (var link in _links) | ||
| { | ||
| if (!EventFrameExchange.SamePhysicalSource( | ||
| link.Key.Source, frame.PhysicalSource)) continue; | ||
| link.Value.PendingPoll = null; | ||
| link.Value.LastResponse = null; | ||
| link.Value.MatchedPoll = null; | ||
| link.Value.Touch = ++_nextTouch; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone: forensic evidence correctness without adding UI bulk
Audited current master after #197/#198; preserve merged Event Journal, validated RX ASDU restoration, Frame Details, Command Panel and release workflows.
Confirmed risk
The previous map retained the last Class 1/2 TX for a physical link until a new TX arrived. Two different RX frames could both claim that same poll as their request within the 45 s time window, and the bounded-Trace fallback skipped intervening secondary replies. That is misleading evidence, especially during IEC-101 FIFO/event drain investigations.
Implementation
EventFrameExchangeTracker: one pending request per (source, link); first physical RX consumes it; FC9/ACK/malformed RX also closes eligibility; same physical RX's sibling IOAs are idempotent and share the one verified TX; new TX supersedes the old poll. Bounded at 256 physical links with deterministic oldest-activity eviction; reset at session clear.FindLatestObservedPollcan only walk backward from the exact RX still present in the chronological Trace, and stops at any intervening response or nonpoll TX. No timestamp-only inference when the source RX was evicted.Regression
New unit cases for one-shot consumption, multi-IOA physical RX fan-out, FC9/FC0 barriers, bad checksum, supersession, dual link separation, passive stream offsets, and bounded tracking. Existing fallback tests strengthened.
Test / merge rule
Normal PR Windows build and all xUnit suites, plus explicit /ci full PR-head Windows GUI smoke and OBS-C screenshot acceptance must pass before merge. This milestone has no installer or release changes; full PR run is correctness evidence only. On real serial hardware, capture provenance still requires field replay.