Repository navigation
fix(ci): isolate fresh-window OBS-C acceptance from prior smoke state - #198
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
/ci full |
| public void ObservationAcceptanceBeginsWithFreshWindowNotMutatedByOtherGuiProbes() | ||
| { | ||
| var root = RepositoryRoot(); | ||
| var source = File.ReadAllText(Path.Combine(root, "src", "ARIEC60870.Desktop", "App.xaml.cs")); |
| var directory = new DirectoryInfo(AppContext.BaseDirectory); | ||
| while (directory is not null) | ||
| { | ||
| if (File.Exists(Path.Combine(directory.FullName, "ARIEC60870.sln"))) |
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
This was referenced Nov 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed failure
The merged milestone CI
masterrun 43389466089 fails only inOBS-C real-WPF viewport and 1400-frame acceptance:In
App.xaml.cs, the--observation-ui-acceptancecommand runsRunPassiveGuiSmokeProbeAsync()andRunPassiveHistoryGuiSmokeProbeAsync()against the sameMainWindowbefore checking clean startup. The first smoke explicitly navigates Event -> Original Frame, which intentionally forces Frame Details open (new behavior added in PR #197).ClearSessionViewmust not silently erase the operator's inspector preference just to satisfy test setup.Fix
--passive-gui-smokeexecutable path is unchanged, continues to test passive GUI, history, and TX/RX Event->Original Frame.No protocol, serial, event correlation, user configuration, shipping installer or XAML changes.
Validation
Previous PR #197 passed 976 xUnit tests and release build, but real WPF acceptance only ran after merge, revealing contamination. This PR must pass full Windows CI in
master(not merely PR xUnit); do not call it fixed without the real OBS-C run.