Repository navigation
fix(android): only configure preferredNetworks when explicitly provided - #2751
Merged
jaynewstrom-stripe merged 1 commit intoOct 19, 2026
Conversation
Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
jaynewstrom-stripe
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2494
On Android, \CustomerSheetManager.kt, \PaymentSheetManager.kt, and \EmbeddedPaymentElementViewManager.kt\ were unconditionally chaining .preferredNetworks(mapToPreferredNetworks(...))\ onto their respective configuration builders.
When \preferredNetworks\ was omitted from options or
ull, \mapToPreferredNetworks(null)\ evaluates to \emptyList(), which sets an explicit empty list on the native configuration builder instead of leaving the property untouched/unset. On iOS, \preferredNetworks\ is guarded by \if let preferredNetworks = preferredNetworks\ (and similarly in \CheckoutConfigurationMapper.kt\ with ?.let), keeping the default native behavior when omitted.
This change ensures that \preferredNetworks\ is only configured when the parameter is non-null.
Testing