Repository navigation
CHORE: Bump urllib3 to 2.8.0 in release dependency locks - #830
dependabot[bot] wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
PR Performance Report⛔ Performance unavailablePerformance could not be assessed because no environment produced a complete result. 0 IMPROVEMENTS 0 SLOWDOWNS 0/2 ENVIRONMENTS Coverage: 0 of 2 environments completed. Advisory result; does not block merging. Unavailable: Unix / SQL Server 2022 (invalid artifact); Unix / SQL Server 2025 (invalid artifact). Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsBuild and measurement detailsPR head: A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Unavailable or rejected data: Linux-SQL2022 (invalid artifact), Linux-SQL2025 (invalid artifact) Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The locks were generated for incorrect Python/platform targets and can fail hash-required CI installations.
Review effort: Balanced
Findings: None
What changed in this PR
Updates urllib3 from 2.7.0 to 2.8.0 in engineering dependency locks.
Changes:
- Updates urllib3 and hashes.
- Regenerates Linux, macOS, and ODBC dependency closures.
| File | Description |
|---|---|
eng/requirements-test-linux.txt |
Updates the Linux test lock. |
eng/requirements-build-odbc.txt |
Updates the ODBC build lock. |
eng/requirements-build-macos.txt |
Updates the macOS build lock. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
b9250b8 to
d6987ea
Compare
| urllib3==2.8.0 \ | ||
| --hash=sha256:0cf3cae568d36aa9576b28dfb35f11328f1cb974ca7647d9475ebb86c75ac6e3 \ | ||
| --hash=sha256:63bf2ead4c879426ebf22ef2a781eeb4aa3b4ae798a0435506f8687fd5bb9b63 |
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.7.0...2.8.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.8.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
d6987ea to
f86101d
Compare
Preserve reviewed dependency closures and universal Python markers while updating urllib3 to 2.8.0. Restore Windows-specific ODBC dependencies using the pinned refresh workflow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The urllib3 2.8.0 artifact hashes and supported Python/platform compatibility cannot be verified offline, so passing lock-regeneration and release-matrix validation jobs must be confirmed before merging.
1 open issue
Review effort: Balanced
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 65.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.4%
mssql_python.pybind.ddbc_bindings.cpp: 80.5%
mssql_python.pybind.connection.connection_pool.cpp: 81.3%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection.cpp: 82.5%
mssql_python.logging.py: 86.2%🔗 Quick Links
|
Work Item / Issue Reference
Summary
Upgrade urllib3 from 2.7.0 to 2.8.0 in release dependency locks. Resolve conflicts against current main and regenerate complete, hash-locked dependency closures while preserving universal Python/platform markers, the Windows-specific ODBC target, and unrelated reviewed dependency versions.