Repository navigation
[Nexthop][m4340nhp] Find NIC_TEMP through eth0 instead of a PCI bus number - #1954
Open
siddarth-nexthop wants to merge 1 commit into
Open
siddarth-nexthop wants to merge 1 commit into
siddarth-nexthop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The m4340nhp
NIC_TEMPembedded sensor points at/sys/bus/pci/devices/0000:02:00.0, but the management NIC's bus number is assigned by PCI enumeration and can move with a BIOS update or a PCIe topology change. If it moves,NIC_TEMPno longer resolves and sensor_service loses the NIC temperatures.This change points the sensor at
/sys/class/net/eth0/deviceinstead, which links to the same PCI device wherever it enumerates.Test Plan
On an m4340nhp running an image built with this change, platform_manager explores clean,
/run/devmap/sensors/NIC_TEMPpoints at the NIC's hwmon node througheth0, andNIC_PHY_TEMPandNIC_MAC_TEMPread normally.