Repository navigation
[Cisco][P200] Fixes for PFC test cases - #1857
Open
itskittycisco wants to merge 2 commits into
Open
itskittycisco wants to merge 2 commits into
itskittycisco wants to merge 2 commits into
Conversation
Tianyu-Meta
approved these changes
Nov 12, 2026
Contributor
|
@Tianyu-Meta has imported this pull request. If you are a Meta employee, you can view this in D131449022. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Issue:
P200 requires SAI_BUFFER_POOL_ATTR_RESERVED_BUFFER_SIZE on the egress pool
create. The SDK uses that reserve when calculating buffer profiles, and the
reserve cannot be changed after a profile is bound.
SaiBufferManager starts the P200 egress pool at getMMUSizeBytes(), 88 MB (92274688), and sets reservedBytes to 20 MB (20971520). Those are local values. Before the single SAI create, the PFC test's FLAGS_egress_buffer_pool_size replaces the size with 1505000 (1,500,000 shared plus 5,000 headroom) and leaves the 20 MB reserve in place. SAI sees one create, size 1505000 and reserve 20971520, and rejects it because the reserve is larger than the pool. The reserve has to fit inside the pool, and that size is fixed on this create.
Fix:
to 50MB (52428800), which holds that reserve. The ingress PFC pool stays
1.5MB with XoffSize 5000, so XOFF still comes from the small ingress
pool. Other ASICs keep the existing small egress pool.
INGRESS_PRIORITY_GROUP_SHARED_WATERMARK is needed only for AgentTrafficPfcGenTest.verifyIngressPriorityGroupWatermarks
Test Plan
Manually verified these following tests on Hw:
Ingress buffer (7):
1 AgentIngressBufferTest.validateConfig. - PASS
2 AgentIngressBufferTest.validateHighBufferValues - PASS
3 AgentIngressBufferTest.validateLossyMode - PASS
4 AgentIngressBufferTest.validatePGHeadroomLimitChange - PASS
5 AgentIngressBufferTest.validatePGParamChange - PASS
6 AgentIngressBufferTest.validatePGQueueChanges - PASS
7 AgentIngressBufferTest.validatePgNoPfc - PASS
PFC config, counters, traffic, and watchdog (12):
1 AgentPfcConfigTest.PfcRxTxCombinations - PASS
2 AgentPfcConfigTest.PfcWatchdogProgrammingSequence - PASS
3 AgentTrafficPfcTest.verifyPfcWithDefaultCfg - PASS
4 AgentTrafficPfcTest.verifyPfcWithMapChanges_0. - PASS
5 AgentTrafficPfcTest.verifyPfcWithMapChanges_1 - PASS
6 AgentTrafficPfcTest.verifyPfcWithScaleCfg - PASS
7 AgentTrafficPfcTest.verifyPfcWithZeroGlobalHeadRoomCfg - PASS
8 AgentTrafficPfcWatchdogTest.PfcWatchdogDetection - PASS
9 AgentTrafficPfcWatchdogTest.PfcWatchdogReset - PASS
10 AgentTrafficPfcZeroPgHeadroomTest.verifyPfcWithZeroPgHeadRoomCfg - PASS
11 AgentTrafficPfcZeroPgHeadroomTest.verifyWithScaleCfgInCongestionDrops - PASS
12 AgentTrafficPfcGenTest.verifyIngressPriorityGroupWatermarks - PASS