Repository navigation
UX P0: unified premium pill buttons, First Event and aligned Trace/Values/Events/GI workspaces - #189
Merged
masarray merged 15 commits intoNov 12, 2026
Conversation
Owner
Author
|
/ci full |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… and fix GI stage clipping
…e and command dock
…ace/Values/Events/Controls/GI
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
Owner
Author
|
/ci full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual audit and changes
User screenshots (full desktop active Master) showed Command Panel actions still using pre-token Primary/Secondary pill styles, tight Grid columns and fixed heights; GI 'Show all stages' was inside a 30 DIP row despite 36 DIP button height; Raw Frames, Values, Events and GI started at different search/table coordinates, while Events WrapPanel could wrap and move its data table.
Implementation
Include: All:ArSeeWorkspaceActionButtonStyle, semantic Open/Close and primary text variants. Applied to text actions across center workspaces, Command Panel, window header and Setup. Nav segmented buttons, left action rail and round icon controls are untouched.No protocol parser, IEC101/103/104 active transaction, serial transport, command safety, or passive RX policy changed. IEC-101 P0 PR #145 kept independent.
Evidence requirement
Final visual refinement from exact WPF screenshots
Real Windows screenshot at constrained 1004px viewport confirmed an additional short-height issue: second Command Panel action row required scrolling. The four Select/Execute buttons have now been moved into a fixed footer outside the scrollable target form, and the WPF acceptance asserts the bottom of each action stays within the panel. No command semantics or safety routing changed.