G
YouTube TikTok Games
Skip to content

UX P0: unified premium pill buttons, First Event and aligned Trace/Values/Events/GI workspaces - #189

Merged
masarray merged 15 commits into
masterfrom
test/command-panel-real-wpf-screenshots-20261112
Nov 12, 2026
Merged

masarray merged 15 commits into
masterfrom
test/command-panel-real-wpf-screenshots-20261112

Conversation

@masarray

@masarray masarray commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Visual audit and changes

User screenshots (full desktop active Master) showed Command Panel actions still using pre-token Primary/Secondary pill styles, tight Grid columns and fixed heights; GI 'Show all stages' was inside a 30 DIP row despite 36 DIP button height; Raw Frames, Values, Events and GI started at different search/table coordinates, while Events WrapPanel could wrap and move its data table.

Implementation

  • Shared 36-DIP premium action pill material derived from Include: All: ArSeeWorkspaceActionButtonStyle, semantic Open/Close and primary text variants. Applied to text actions across center workspaces, Command Panel, window header and Setup. Nav segmented buttons, left action rail and round icon controls are untouched.
  • Command Panel top four buttons and Select/Execute actions use the same material, with explicit 32/34 DIP heights and 120 DIP minimums removed. Open and Close retain restrained semantic text color without heavy colored shapes.
  • Shared 12-DIP inset, 36-DIP toolbar and 6-DIP gap for Raw Frames, Values, Events, Controls, GI. Events uses a single fixed row with anchored search and horizontally scrollable action strip (wheel/touch/keyboard focus), preventing action wrap from moving the data grid.
  • First Event next to Latest Event: jumps to original oldest indexed matching Event Journal page (not UI ring). Does not alter filters or fabricate source facts; bounded, indexed page flow is preserved.
  • GI Show all stages receives a true 44-DIP row and 36-DIP token button to prevent clipping.
  • Real Windows WPF screenshot acceptance expanded for Command Panel and Events/GI; asserts shared action templates, GI button geometry, Event single row and <=2.5-DIP search/table origin drift across five main workspaces.
  • Regression tests exercise indexed First and Latest navigation.

No protocol parser, IEC101/103/104 active transaction, serial transport, command safety, or passive RX policy changed. IEC-101 P0 PR #145 kept independent.

Evidence requirement

  • Exact-head Windows Release / protocol smoke / xUnit / real-WPF viewport acceptance and screenshot inspection prior to merge.
  • Avoid installer upgrade workflow; this is a UI consistency change, not installer FAT.
  • UI screenshots from Windows Actions are source-backed WPF, not mockups; hosted runner physical DPI is not field FAT.

Final visual refinement from exact WPF screenshots

Real Windows screenshot at constrained 1004px viewport confirmed an additional short-height issue: second Command Panel action row required scrolling. The four Select/Execute buttons have now been moved into a fixed footer outside the scrollable target form, and the WPF acceptance asserts the bottom of each action stays within the panel. No command semantics or safety routing changed.

Copy link
Copy Markdown
Owner Author

/ci full

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T08:28:58.307577Z dbf5b0b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray masarray changed the title test(wpf): capture actual Active Master Command Panel screenshots UX P0: unified premium pill buttons, First Event and aligned Trace/Values/Events/GI workspaces Nov 12, 2026

Copy link
Copy Markdown
Owner Author

/ci full

Copy link
Copy Markdown
Owner Author

/ci full

Copy link
Copy Markdown
Owner Author

/ci full

Copy link
Copy Markdown
Owner Author

/ci full

@masarray
masarray merged commit 35ed55e into master Nov 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant