Repository navigation
UX: compact hierarchical Frame Details with aligned Name / Value columns - #161
Conversation
|
/ci full |
| { | ||
| var rows = FrameInspectorTreePresentation.Build( | ||
| SelectedFrameProperties.ToArray(), _expandedFramePropertyKeys); | ||
| // Preserve the scroll position as far as possible on disclosure toggles: | ||
| // update only the changed span rather than clearing the whole DataGrid. | ||
| var prefix = 0; | ||
| while (prefix < VisibleFrameProperties.Count && prefix < rows.Count && | ||
| Equals(VisibleFrameProperties[prefix], rows[prefix])) | ||
| prefix++; | ||
| var suffix = 0; | ||
| while (suffix < VisibleFrameProperties.Count - prefix && | ||
| suffix < rows.Count - prefix && | ||
| Equals(VisibleFrameProperties[VisibleFrameProperties.Count - suffix - 1], | ||
| rows[rows.Count - suffix - 1])) | ||
| suffix++; | ||
| while (VisibleFrameProperties.Count > prefix + suffix) | ||
| VisibleFrameProperties.RemoveAt(prefix); | ||
| for (var i = prefix; i < rows.Count - suffix; i++) | ||
| VisibleFrameProperties.Insert(i, rows[i]); | ||
| } |
|
/ci full |
…ligned field columns
|
/ci full |
…taining full label tooltip
|
/ci full |
1 similar comment
|
/ci full |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52dbd3d02b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ToolTipService.IsEnabled="False" RowDetailsVisibilityMode="VisibleWhenSelected" | ||
| IsReadOnly="True" AutoGenerateColumns="False" CanUserSortColumns="False" | ||
| <DataGrid x:Name="FramePropertiesGrid" | ||
| ItemsSource="{Binding VisibleFrameProperties}" |
There was a problem hiding this comment.
After opening Frame Details and selecting a frame, clearing the selection or resuming the live view leaves that frame's properties displayed. ApplySelectedEvidenceRowToInspector(null) still clears only SelectedFrameProperties, whereas this grid now binds to VisibleFrameProperties; the original HEX area resets while the decoded properties remain stale. Clear the visible projection and expansion keys in the null-selection path as well so properties from an earlier selection or session are not presented as current evidence.
Useful? React with 👍 / 👎.
| <DataGridTemplateColumn.CellTemplate> | ||
| <DataTemplate> | ||
| <Grid VerticalAlignment="Center" Margin="8,5,4,5"> | ||
| <Grid Height="25" ToolTipService.IsEnabled="True" ToolTip="{Binding NameTooltip}"> |
There was a problem hiding this comment.
With Frame Details open, hovering any property name now opens its explanation over the evidence, and value cells and disclosure buttons also introduce tooltips. This reverses the previous tooltip-disabled inspector and violates the current R6 rule in AGENTS.md prohibiting intrusive hover popups/tooltips on the inspector. Preserve access to complete labels, values and explanations through an explicit selected-field detail surface rather than enabling hover overlays.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
| TraceInspectorColumn.MinWidth = 325; | ||
| // One engineer mode: the raw/decoded trace still owns the majority | ||
| // of horizontal space, and the operator may drag the splitter. | ||
| TraceInspectorColumn.Width = new GridLength(1.55, GridUnitType.Star); |
There was a problem hiding this comment.
This change raises the inspector's minimum width from 250 to 325 DIP and changes its share of the trace workspace, but the commit contains no documentation updates. AGENTS.md explicitly requires updating docs/RESPONSIVE_LAYOUT_POLICY.md when changing layout. Document the new dock sizing and compact property-tree behavior there so the repository's responsive-layout contract reflects the implementation.
AGENTS.md reference: AGENTS.md:L259-L259
Useful? React with 👍 / 👎.
Engineer observation UI — selected-frame hierarchy
Screenshot-driven P1 Frame Details fix. The prior DataGrid RowDetails stacked explanatory paragraphs under every value, causing excessive wrapping and unstable column alignment (especially Quality, IOA and object children).
Changes
Quality → Quality details → IV/NT/BL/SB/rawproperty hierarchy, as in the supplied reference image. Only canonical decoded bits are listed. Values and explanations have hover tooltips; no inline encyclopedic paragraphs.Verification
The exact PR head should pass selective Windows build/test, CodeQL; request full Windows WPF viewport and GUI package test via
/ci fullafter selective gate passes. This PR is independent of P0 IEC-101 engine Draft #145 and installer PR #160; do not bundle them without reconciliation.Release
Do not merge before exact-head CI and real WPF acceptance; released RC remains unchanged.