Repository navigation
Desktop: ArSee versioned window title • IEC 101/104/103 - #157
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05ed3700a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| xmlns:input="clr-namespace:System.Windows.Input;assembly=PresentationCore" | ||
| xmlns:vm="clr-namespace:ARIEC60870.Desktop.ViewModels" | ||
| Title="ArSee · Open Source IEC 60870-104/103/101 Protocol Tester" | ||
| Title="ArSee • Open Source IEC 60870-101/104/103 Protocol Tester & Analyzer" |
There was a problem hiding this comment.
The new caption contains an unescaped & in both MainWindow.xaml and ARIEC60870.Desktop.csproj. Both files are invalid XML (confirmed by parsing), so MSBuild cannot load the Desktop project and the application cannot be built. Replace the literal ampersands with & in both XML files; the C# caption string should retain its literal ampersand. This violates the root AGENTS.md requirement that XAML visual changes remain compile-safe.
AGENTS.md reference: AGENTS.md:L324-L324
Useful? React with 👍 / 👎.
| public MainWindow() | ||
| { | ||
| InitializeComponent(); | ||
| Title = ArSeeWindowTitle.ForAssembly(typeof(MainWindow).Assembly); |
There was a problem hiding this comment.
This changes the user-visible window caption to include the executable's version, preserving prerelease identifiers and removing build metadata, but the commit updates none of the documentation required by the root AGENTS.md behavior-change rule. Add a short explanation to an allowed document, such as README.md, or the version's release notes so the change satisfies the repository's explicit documentation gate.
AGENTS.md reference: AGENTS.md:L261-L265
Useful? React with 👍 / 👎.
Scope
Implement requested application window caption:
ArSee • Open Source IEC 60870-101/104/103 Protocol Tester & Analyzer • version X.Y.Z[-rc.N]AssemblyInformationalVersionAttribute, preserving the actual RC suffix while removing SemVer build metadata (+release,+p0-...).$(Version)so release-package stamping remains authoritative.No IEC101 transaction, GI, command, serial, RTU or passive monitor behavior altered. Source is based directly on
master@e2124c70571736cbedf41aabb30540bac21b322a. Scope is isolated from IEC101 P0 draft #145 and legacy #136.Gate
Run the normal selective PR checks for Desktop and its unit tests. Inspect exact-head Windows result and only then merge. This PR does not update public
v3.6.8-rc.4assets or claim field FAT.