Repository navigation
P0 IEC101 T02: bounded unchanged-frame read retransmission in shared single/A-B engine - #148
Merged
masarray merged 7 commits intoNov 10, 2026
Conversation
One unchanged-FCB retransmission after pure silence, never on mutating FC3, invalid/out-of-context secondary or stale epoch. Shared by single and A/B core, with deterministic FC9/FC10/FC11 positive and negative tests.
…le and dual runtime Both orchestrators use the same per-link T02 retry guard, maintain a single pending exchange, defer terminal timeout until retry exhaustion, surface a separately labeled physical TX retry, and never resend potentially mutating FC3.
…ssion Add real single-session no-RX fixture and document grade-A T02 behavior, safety exclusions and remaining physical FAT/late-response ambiguities.
…us without false failure Use deterministic addressed FC11 responder after exactly one lost FC9, confirm identical TX bytes, validated RX, zero terminal timeouts and physical retry evidence. Defer per-exchange observer verdict until final retry.
masarray
changed the base branch from
feat/iec101-shared-transaction-core-20261111
to
master
November 10, 2026 22:09
… unchanged retry Drop the active link's first FC9 response, require identical second TX, actual addressed recovery, no false failure/failover and visible source-qualified retry evidence.
Require two actual lost responses to exhaust the one-retry budget before failover. Validate addressed FC11 through retained source-qualified wire evidence rather than transient health snapshot cleared during Stop.
…rrive Do not confuse no decoded secondary with true serial silence. Shared per-link frame reader exposes read-only consumed byte count; single/A-B orchestration checks it before authorizing unchanged poll retransmit. Add incomplete FT12 negative test and update safety contract.
masarray
changed the base branch from
master
to
feat/iec101-shared-transaction-core-20261111
November 10, 2026 22:24
masarray
marked this pull request as ready for review
November 10, 2026 22:25
masarray
merged commit Nov 10, 2026
306f36e
into
feat/iec101-shared-transaction-core-20261111
6 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEC101 P0 T02 — bounded unchanged read retry, stacked on #145
Implementation
0x10blocks retry.Exact-head evidence at
7826980e(based on parent #145 at eac974d)dotnet format --verify-no-changesreports 1,221 mostly pre-existing WHITESPACE issues across 61 files; workflow marks this diagnosticcontinue-on-error. Not falsely claimed as formatting-clean. Separately track repository-wide cleanup, do not rewrite unrelated modules in the IEC-101 safety PR.Integration route: this PR is stacked onto draft parent #145, and must NOT merge into public master independently. Parent #145 must reconcile current master
59ebc36f(UI PR #147), remain Draft until remaining software/physical acceptance and approved release gate.