Repository navigation
fix(exec): preserve fragment scope in top-k late materialization - #11097
Open
zhangyue19921010 wants to merge 2 commits into
Open
zhangyue19921010 wants to merge 2 commits into
zhangyue19921010 wants to merge 2 commits into
Conversation
Problem Top-k late materialization can remove a fragment-scoped row-stream read and return rows from excluded fragments. Solution Keep scoped row-stream reads below the sort, alongside the existing physical-selection guard. Result Add optimized-versus-unoptimized result checks for single, multiple and empty fragment scopes, plus the unscoped optimization control, across both row-ID modes and top-k partitioning shapes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Top-k late materialization can remove a fragment-scoped row-stream read and return rows from excluded fragments.
Solution
Keep scoped row-stream reads below the sort, alongside the existing physical-selection guard. Unscoped plans retain the optimization.
Result
All 61 top-k tests pass, including 16 cases covering single, multiple and empty fragment scopes, the unscoped control, both row-ID modes and both partitioning shapes. The same test code has 12 scoped failures on unchanged upstream production code.
cargo fmt --alland full-workspacecargo clippy --locked --profile ci --all --tests --benches -- -D warningspass.Fixes #11096