Repository navigation
Add include_invoice_components option to Account.paginated_invoices - #128
Draft
tungleduyxyz wants to merge 1 commit into
Draft
tungleduyxyz wants to merge 1 commit into
tungleduyxyz wants to merge 1 commit into
Conversation
Paginated account invoices are shallow, so amount and balance are 0. Optionally send includeInvoiceComponents=true so the server loads the components of the invoices of the requested page. The new argument is last, so existing callers are unaffected. See killbill/killbill-admin-ui#678 and killbill/killbill#2334 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional trailing argument
include_invoice_components(defaultfalse) toAccount.paginated_invoices. When true, the client sendsincludeInvoiceComponents=trueso the server loads the components (amount, balance, items) for the invoices of the requested page only. Existing callers and the default request are unchanged.Depends on killbill/killbill#2334 (server support); draft until that is released.
Refs killbill/killbill-admin-ui#678
Testing
New
spec/killbill_client/account_spec.rbchecks the query params with and without the flag.🤖 Generated with Claude Code