Repository navigation
fix(firebase_ai): export LiveServerSetupComplete - #18963
Open
jamesblasco wants to merge 1 commit into
Open
jamesblasco wants to merge 1 commit into
jamesblasco wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request exports LiveServerSetupComplete from the public API in firebase_ai.dart and adds a unit test in live_test.dart to verify that setup completion can be correctly identified through the public API. I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Live API setup responses produce a
LiveServerSetupCompletemessage, but this type is missing from the public package exports. Callers importingpackage:firebase_ai/firebase_ai.dartcannot check for it to identify successful setup.Export the existing type and add a regression test that identifies a parsed setup-completion message through the public API. This is an additive change, independent of usage metadata support in #18962.
Validation
flutter test --no-pub --reporter expanded test/live_test.dart: 32 tests passed.flutter analyze --no-pub lib test: no issues found.git diff --check: passed.Breaking Change
No.