Repository navigation
Conversation
tianon
reviewed
Oct 30, 2026
thaJeztah
force-pushed
the
add_validate
branch
from
November 6, 2026 03:08
466c135 to
6ba0b64
Compare
Return only the reason for validation failure from validateSpecifierComponent, and make callers responsible for including the invalid value and its context. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_validate
branch
from
November 9, 2026 10:01
6ba0b64 to
421109c
Compare
thaJeztah
force-pushed
the
add_validate
branch
2 times, most recently
from
November 9, 2026 10:18
ce94d38 to
5013b03
Compare
Add Validate to check that a platform has non-empty OS and architecture fields and that its components are well-formed. Validation follows the existing platform specifier syntax, rejecting invalid characters and path components such as "." and "..", without restricting values to known or supported platforms. This allows callers to validate platform specifications without formatting, parsing, or normalizing them. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_validate
branch
from
November 9, 2026 10:19
5013b03 to
c5144e3
Compare
Validate OSVersion and OSFeatures against the existing OS-option syntax, accounting for escaped characters. Reject malformed values and empty OS features, and add tests covering valid and invalid metadata. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
marked this pull request as ready for review
November 9, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platforms: add Validate utility for OCI platform specifications
Add Validate to check that a platform has non-empty OS and
architecture fields and that its components are well-formed.
Validation follows the existing platform specifier syntax, rejecting
invalid characters and path components such as "." and "..", without
restricting values to known or supported platforms.
This allows callers to validate platform specifications without
formatting, parsing, or normalizing them.