Repository navigation
Support new commands in v9, replace old command GraphQL method - #134
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 27.47% 27.47%
=======================================
Files 20 20
Lines 404 404
=======================================
Hits 111 111
Misses 286 286
Partials 7 7 Continue to review full report at Codecov.
|
wu-sheng
approved these changes
Jan 14, 2022
wu-sheng
added a commit
that referenced
this pull request
Nov 7, 2026
infra-e2e #132 (pulled in by the cf589b4 -> 56ac8be bump in #240) makes the http trigger stop after `times` requests. Before it, `times` only decided when the trigger reported its first result, and the requests kept going until the verify phase finished. The basic case's `times: 10` now means 30 seconds of traffic, and the nightly CI failed on 3 of the 4 nights since #240, every time on `metrics linear service_relation_client_cpm`, whose whole 30-minute window came back empty while the other 15 cases passed. `times: -1` (endless, infra-e2e #134) restores the continuous traffic, the same as the live-debugging case.
wu-sheng
added a commit
that referenced
this pull request
Nov 7, 2026
…tions/setup, and stale docs (#242) * Fix the Go version in actions/setup and stale build/release docs before 0.16.0 actions/setup installed Go 1.24, while go.mod requires go 1.26.0 since #227. setup-go exports GOTOOLCHAIN=local, so the build either fails or, where sudo drops that variable, downloads the go1.26.0 toolchain instead of using the latest 1.26 patch. It now installs "1.26", like CI. README: - Build from source: needs Go 1.26+; `make build` only builds, a plain `make` also runs license/lint/test (license-eye, golangci-lint); the binaries are swctl-<version>-<os>-<arch> for the seven platforms, not swctl-latest-<os>-amd64. - The GitHub Actions example used `apache/skywalking-cli@main`; the default branch is `master`, there is no `main`. CONTRIBUTING: - Compiling: Go 1.26+, seven binaries, not three. - How to release: the tag has no `v` prefix and is pushed only after `make release` succeeds; three links pointed at How-to-release.md anchors that do not exist; mention pre-release.sh and release.sh. How-to-release.md: fix the unclosed BuildKit link. * Keep the basic e2e trigger running until verification ends infra-e2e #132 (pulled in by the cf589b4 -> 56ac8be bump in #240) makes the http trigger stop after `times` requests. Before it, `times` only decided when the trigger reported its first result, and the requests kept going until the verify phase finished. The basic case's `times: 10` now means 30 seconds of traffic, and the nightly CI failed on 3 of the 4 nights since #240, every time on `metrics linear service_relation_client_cpm`, whose whole 30-minute window came back empty while the other 15 cases passed. `times: -1` (endless, infra-e2e #134) restores the continuous traffic, the same as the live-debugging case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gettoinstanceandendpoint.9.0.0version check.