Repository navigation
Conversation
Promote float16 and float32 observations before reducing statistics and computing pair distances. Preserve wider floating types and exact integer calculator inputs. Add regressions for large-offset means and t-test decisions, float16 distance overflow, native detector and split/merge boundaries, and exact large-integer distances.
Gerrrr
marked this pull request as ready for review
November 10, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Float16/float32 inputs can lose a detected change point because reductions round different group means to the same value. Large float16 distances can also overflow. Promote statistical inputs to at least float64 before calculating means and sample standard deviations, and promote lower-precision floating calculator inputs before computing distances.
Preserve exact integer calculator inputs and wider floating types. Add ten regression cases covering accurate statistics, consistent t-test decisions and detected boundaries, float16 distance overflow, and large integer differences.