Repository navigation
Fixed various IntelliJ warnings in BaseActivator - #2911
Open
CptBartender wants to merge 2 commits into
Open
CptBartender wants to merge 2 commits into
CptBartender wants to merge 2 commits into
Conversation
jbonofre
requested changes
Sep 16, 2026
CptBartender
marked this pull request as draft
October 3, 2026 08:55
CptBartender
marked this pull request as ready for review
October 3, 2026 13:06
Member
|
@CptBartender thanks, I'm doing a new pass. |
jbonofre
self-requested a review
October 3, 2026 13:07
CptBartender
force-pushed
the
modernize-base-activator
branch
from
October 3, 2026 13:44
ba4b0fa to
8f6d222
Compare
jbonofre
requested changes
Oct 4, 2026
jbonofre
requested changes
Oct 4, 2026
jbonofre
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates!
I left a few more comments inline. The main one is still the Java baseline.
Added type parameters to generics Extracted the string splitting pattern to a static field so that the regex is compiled only once Changed getInterfaceNames so that it returns distinct classes in case any implemented interfaces extend the same superinterface Extracted `getTrackedService` logic to an internal method used by all 3 overloads
CptBartender
force-pushed
the
modernize-base-activator
branch
from
October 4, 2026 19:04
583a1dc to
fb32517
Compare
jbonofre
requested changes
Oct 6, 2026
….java Co-authored-by: JB Onofré <jbonofre@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instanceofcan be used - eventually it'll be bumped in Lift minimum JDK version to 21 and remove SecurityManager #2214, I presume