Repository navigation
feat: propose a Quarkus extension for Fesod - #1327
Draft
tanujkapoor-cmd wants to merge 1 commit into
Draft
tanujkapoor-cmd wants to merge 1 commit into
tanujkapoor-cmd wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #615
I tried reading an XLSX file in a small Quarkus app. Fesod worked on the JVM as a plain dependency. The idea here is to give apps a shared reader they can inject and a batch size they can set with
quarkus.fesod.batch-size.What's changed?
SpreadsheetReaderreads the first worksheet and hands typed rows to the caller in batches. It uses Fesod's existing reader and leaves the input stream with the caller. Thequarkus-extensionMaven profile builds the extension against Fesod from this checkout on JDK 17. The core modules still target Java 8.The integration test sends a two-sheet XLSX workbook through a Quarkus app. It checks that only the first sheet is read, that invoice IDs and amounts come back correctly, and that five rows are delivered as batches of 2, 2, and 1.
The core tests (excluding fuzz tests) and both Quarkus tests passed on JDK 17. I ran this from the repo root.
Would this be a useful first scope for #615? In particular, should the first version support JVM apps, or is native XLSX support what you had in mind?
Checklist
I used OpenAI Codex to prepare this draft and Quarkus's Maven scaffold to start the extension layout.