Repository navigation
Fix abbreviation overflow for extreme negative offsets - #1875
Open
AmarGhugare wants to merge 1 commit into
Open
AmarGhugare wants to merge 1 commit into
AmarGhugare wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringUtils.abbreviate("abcdefghijklmno", Integer.MIN_VALUE, 10)returns...ijklmnoinstead ofabcdefg.... Negative offsets already select the beginning in the documented examples, but the length-minus-offset subtraction overflows for sufficiently negative values and incorrectly selects the tail branch.Perform that subtraction in
longarithmetic. The existing comparison and abbreviation behavior are preserved without adding an API. Regression tests cover both offset overloads, values on either side of the overflow boundary, ordinary negative/zero offsets, and custom/empty/null markers. Six cases fail without the fix.Validation:
mvn -o -B -ntppassed on JDK 25.0.4.1: 119,340 tests run, zero failures/errors, and 18 skipped. Coverage, license checks, Checkstyle, binary compatibility, SpotBugs, PMD, and Javadoc checks passed.Jira filing is pending approval of the Apache Jira account. The reproduction and proposed fix are included here for review in the meantime.