Repository navigation
Conversation
…t=json has only JSON, and an endpoint that matches nothing is not found The receive console took the message timestamp, which is 0 for most components, so --since never filtered: it falls back to the time the exchange was created. --action=status --output=json printed the table, the JSON stream started with 'Starting to receive ...' on stdout, --action=stop said 'Starting to receive', and a start with an endpoint that matched nothing exited 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
🔄 Backport BotThis bugfix targets
Add a Backport PRs will be created automatically on merge (once a port label is added). Comment ℹ️ If you push additional commits after |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Clean, well-tested fix across three concerns: timestamp fallback for --since filtering, JSON-only stdout in --output=json mode, and exit code 3 for no matching endpoint. All guards are correct, JSON/text parity is maintained, and all three behavior changes are covered by tests.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 19 of 726 tested, 25 compile-only — current: 19 all testedMaveniverse Scalpel detected 19 affected modules (current approach: 19). Skip-tests mode would test 19 modules (3 direct + 18 downstream), skip tests for 25 (generated code, meta-modules) Modules Scalpel would test (19)
Modules with tests skipped (25)
💡 Manual integration tests recommended:
All tested modules (46 modules, 7m 23s total)Total reactor time: 7m 23s
Top 20 slowest modules:
|
Part of item 4 of CAMEL-26929:
camel cmd receive.Problems and changes
--sincenever filtered. The receive console recorded the message timestamp, which is 0 for most components, and the CLI keeps a message without a timestamp.ReceiveDevConsole(camel-console) now records the time the exchange was created when the message has no timestamp.--action=stopsaid "Starting to receive messages ...". It says "Stopping to receive messages ...".--output=jsonstarted with "Starting to receive ..." on stdout. With--output=json, that line goes to stderr, so stdout has only the JSON.--action=status --output=jsonprinted the table. It prints a JSON list:pid(a number),name,uptime,enabled,total,firstTimestampandlastTimestamp(when known), andendpoint(masked with--mask, as in the table).The 4.24 upgrade guide has a line in the exit codes entry.
Tests
ReceiveDevConsoleTest.testAMessageWithoutTimestampHasTheTimeItWasReceived(camel-console, a realdirectendpoint): the timestamp is the time of the send. It was 0 without the change.CamelReceiveActionTest: stop says "Stopping";--endpoint=nope*that the integration finds nothing for exits 3;--endpoint=... --output=jsonhas only JSON lines on stdout and the start line on stderr;--action=status --output=jsonis a list with the pid as a number and the password masked.endpointStartsReceivingAndDumpsTheMessagesnow answers with a URL, as the integration does.Claude Code on behalf of davsclaus
🤖 Generated with Claude Code