Repository navigation
Conversation
…the Citrus tests The export took its exporters from the plugin configuration only, and the launcher embeds the test plugin without registering it there, so camel export from the launcher never had the Citrus tests (src/test was missing), unlike after camel plugin add test. CamelJBangMain.getEmbeddedPlugins(target) gives the plugins built into the CLI that contribute to a command: the launcher returns its embedded plugins whose PluginType lists the command (the test plugin for export). CliExportContext adds them to the plugins of the configuration, unless the configuration has the same plugin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
🔄 Backport BotThis bugfix targets
Add a Backport PRs will be created automatically on merge (once a port label is added). Comment ℹ️ If you push additional commits after |
gnodet-bot
left a comment
There was a problem hiding this comment.
The Javadoc for getEmbeddedPlugins was inserted between the existing postAddCommands Javadoc and the postAddCommands method itself, orphaning the original documentation:
/**
* Called after default commands has been added
*/
// ← new method inserted here ↓
/**
* The plugins that this CLI has built in...
*/
public Collection<Plugin> getEmbeddedPlugins(String target) { ... }
public void postAddCommands(...) // ← lost its JavadocJava associates the closest preceding /** */ block with the declaration, so postAddCommands ends up undocumented. Move getEmbeddedPlugins (and its Javadoc) after postAddCommands, or move the postAddCommands Javadoc to just above postAddCommands.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
…which keeps its Javadoc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet-bot
left a comment
There was a problem hiding this comment.
Previous finding addressed. ✅
The Javadoc for getEmbeddedPlugins is now correctly placed after postAddCommands — postAddCommands retains its Javadoc, and no documentation is orphaned. No new issues found.
LGTM.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 5 of 726 tested, 7 compile-only — current: 5 all testedMaveniverse Scalpel detected 5 affected modules (current approach: 5). Skip-tests mode would test 5 modules (2 direct + 5 downstream), skip tests for 7 (generated code, meta-modules) Modules Scalpel would test (5)
Modules with tests skipped (7)
💡 Manual integration tests recommended:
All tested modules (14 modules, 2m 24s total)Total reactor time: 2m 24s
Top 20 slowest modules:
|
Item 1 of CAMEL-26933.
Problem
camel exportfrom the launcher never exports the Citrus tests.CliExportContexttakes the exporters fromPluginHelper.getActivePlugins, which reads only~/.camel-jbang-plugins.json. The launcher embeds the test plugin and callsplugin.customize(CamelLauncherMain) without registering it, soTestPluginExporternever runs: the export exits 0 andsrc/testis missing. Aftercamel plugin add testthe tests are exported, andcamel-jbang-test.adocsays they are.On the launcher from main, with
hello.yamlandtest/hello.citrus.it.yaml:Change
CamelJBangMain.getEmbeddedPlugins(target)(new, none by default): the plugins built into the CLI that contribute to a command.CamelLauncherMainreturns its embedded plugins whosePluginTypelists the command inappliesTo. Today that is the test plugin forexport.CliExportContextadds them to the plugins of the plugin configuration, unless the configuration has the same plugin (aftercamel plugin add test), so an exporter does not run twice.After, on the launcher built from this branch:
Tests
CliExportContextEmbeddedPluginsTest: the export has the exporter of an embedded plugin; without embedded plugins, only those of the configuration.CamelLauncherMainEmbeddedPluginsTest: the launcher's test plugin contributes to export with its exporter, and to run nothing.DependencyUpdateTestfailed once and passed on the rerun, as on other branches). camel-launcher: 416 pass.Claude Code on behalf of davsclaus
🤖 Generated with Claude Code