G
YouTube TikTok Games
Skip to content

[CI] Core CI doesn't run for changes to amoro-format-lance (and amoro-web) #4417

Open

Description

@MarkAlex1234

What happens

core-hadoop2-ci.yml and core-hadoop3-ci.yml build and test the whole reactor (./mvnw clean install ...), but on pull requests they only trigger on an explicit module list: amoro-ams, amoro-common, amoro-metrics, amoro-optimizer, amoro-format-{iceberg,paimon,hudi} and three amoro-format-mixed submodules. amoro-format-lance was added to the root pom.xml modules later and isn't in either list, and no other workflow mentions it.

amoro-ams/pom.xml depends on amoro-format-lance (test scope, plus compile scope in two profiles). So a PR that only changes amoro-format-lance/** runs no CI at all, neither lance's own tests nor the AMS tests that use it, and breakage only shows up on the next PR that touches a listed module.

amoro-web is in the same position: amoro-ams depends on the amoro-web artifact, but no workflow watches amoro-web/**. That may be intentional, since frontend-only changes would otherwise run the full core matrix, so I'm only flagging it.

Proposed fix

Add "amoro-format-lance/**" to the pull_request.paths of core-hadoop2-ci.yml and core-hadoop3-ci.yml. I have a two-line PR ready and will link it here.

(Found by comparing each workflow's paths: with the Maven module graph using npx github:Continuous-Actions/dynamic-monorepo audit. Disclosure: that's a GitHub Action I maintain. The fix itself is just the path entry.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions