Repository navigation
Conversation
Return Close, Back and scoped Escape to the originating state button in either split pane while preserving Review and Merge focus behavior. Cover all dismissals with the production Electron/main path and a synthetic gh, asserting no mutation or provider start. Reconcile protected seed delivery and retain human and live-write acceptance gates.
Retain the failed broad local result and unchanged reviewed application inputs, with fresh hosted qualification still required.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dismissing a Code Review state-change preview with Close or Back left keyboard focus on the document body; scoped Escape left it open. Reuse the pane-local header close handler so Close, Back and Escape return focus to the originating Overview or Changes state button. Main retains the existing preview-bound confirmation authority, and dismissal performs no mutation or provider start.
Six new state-panel regressions failed before the repair. Eight split-pane Electron cases now cover Close/Back/Escape in both panes plus the preserved Review/Merge controls, with no synthetic writes or provider turns. The scoped source review found no remaining Critical or Important issue. Coverage is dismissal before a confirmed write starts; human accessibility and named-disposable-repository live-write acceptance remain open.
Final signed
ff353c0c0900ee4090985f897ba4e44e65c55d7fpassed fresh full build/typechecking, eight focus E2E cases, eight site cases and four web cases, with no retries and unchanged source hashes. Its only changes after reviewed signed0f96bd4are two documentation files; all application, test and configuration inputs remain byte-identical to the full unit run with 2,588 passed and 36 skipped. Both branch commits have verified approved source signatures.The retained broad local E2E run at
0f96bd4failed: 539 passed, 17 skipped and one window-position relaunch assertion; site/web did not run in that invocation. Separate observations recorded valid saved/planned bounds followed by native movement into the assigned display. A private same-code host passed two unchanged persistence controls, but a later read found it assigned to the same macOS Desktop too; assignment provenance is unknown. First failures and traces remain retained, OS preferences and assertions were unchanged, and no complete local E2E or product persistence repair is claimed. Fresh complete hosted source CI and protected merge-queue checks remain required.This advances #322, #326 and #327 without changing their acceptance checkboxes or activation decision. See the repair receipt for failure evidence, review scope and remaining gates.