Repository navigation
Conversation
Accept bytes input instead of str, iterating over raw byte values rather than Unicode code points. This makes output match zlib.adler32 for all inputs including non-ASCII text. Add TypeError for non-bytes input (consistent with hashes/crc32.py). Add doctests comparing against zlib.adler32 for ASCII, non-ASCII, and empty inputs. Fixes TheAlgorithms#15635
This was referenced Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15635
Describe your change
hashes/adler32.py: acceptbytesinput instead ofstr, iterating over raw byte values rather than Unicode code pointszlib.adler32(data.encode())for all inputs, including non-ASCII textTypeErrorfor non-bytes input (consistent withhashes/crc32.py)zlib.adler32for ASCII, non-ASCII, and empty inputsChecklist
ruff checkandruff formaton my changesFixes #15635