Repository navigation
Remove Serilog from PackageUpdateLib - #682
Open
SimonCropp wants to merge 1 commit into
Open
SimonCropp wants to merge 1 commit into
SimonCropp wants to merge 1 commit into
Conversation
The lib now logs only through a Microsoft.Extensions.Logging ILogger passed to PackageUpdater.Run, and logs nothing when none is given. The tool bridges its Serilog logger in via Serilog.Extensions.Logging. SerilogNuGetLogger is replaced by an internal NuGetLogger that forwards NuGet.Protocol logging to the ILogger.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lib should not have an opinion on logging, so it no longer references Serilog.
Microsoft.Extensions.LoggingILogger, via a newPackageUpdater.Run(directory, package, build, progress, logger)overload. The existing overloads remain and log nothing.Updater.Update,Updater.GetLatestVersionandToolUpdater.Updatetake an optionalILogger; internally the logger is passed down explicitly (no static or ambient state).SerilogNuGetLoggeris replaced by an internalNuGetLoggerthat forwards NuGet.Protocol logging to theILogger. The NuGet code, project path and warning level are passed as a logging scope.Serilog.Extensions.Logging, so console and file output are unchanged.Breaking for lib consumers on 4.8.0 who relied on the lib writing to Serilog's global
Log.Logger: they now need to pass anILogger. The publicSerilogNuGetLoggertype is removed.