G
YouTube TikTok Games
Skip to content

Principled IOR mismatch #16

Open
Open

Description

@PearCoding

The ior from the principled bsdf (aka. disney bsdf) does not work for all ior values. IOR=1 returns just black

Activity

  1. pgrit commented on Feb 3, 2022

    @pgrit
    Collaborator

    IOR=1 is a NaN causing corner-case for microfacet distributions. Because there's no such thing as a rough yet non-existent interface between two media ;)

    You could add a special case that switches to a non-rough dielectric, or simply enforce a lower bound of 1.00001 or sth.

  2. PearCoding commented on Feb 3, 2022

    @PearCoding
    OwnerAuthor

    True, but the behavior is inconsistent in the implementation. The rough dielectric bsdf has no problem dealing with it... the principled bsdf however does. So there is a "happy accident" somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions