G
YouTube TikTok Games
Skip to content

Selecting a layer which is already selected should deselect it #476

Closed

Description

@Bentroen

By @OverlordVizeon on Discord:

Suggestion: If the layer you wish to select is already selected, it should deselect it

Considerations:

  • Right now the program doesn't keep track of which layers have been selected, as selections operate purely at note block level. As such, we can't detect if a layer is entirely selected without checking all notes in the layer.
  • One way around it would be checking only the first (leftmost) note block in the layer and using it to determine if the layer is selected. This would 'work' for most purposes but would lead to a bit of inconsistent behavior.
  • Alternatively, shift-clicking the 'Select all blocks in this layer' button could be used as a shortcut to deselect the layer, regardless of its current selection status. Though this is a bit more cumbersome in terms of UX than a simple toggle.

Relates to: #464

Activity

  1. OctoFlareDev commented on Oct 22, 2024

    @OctoFlareDev
    Collaborator

    I think right clicking the select layer button to deselect would be a good way to go, since it's also the way to deselect individual notes

  2. added a commit that references this issue on Dec 2, 2024
    a36c71e
  3. added this to the v3.11 milestone on Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions