Repository navigation
fix(tvm-ffi): env stream detection for tuple parameters - #3464
Merged
Merged
Conversation
SamJSui
marked this pull request as ready for review
August 17, 2026 23:57
Contributor
|
LGTM @Junkai-Wu The fix has landed internally, can you help merge this one? Thanks |
Junkai-Wu
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.TupleParam.paramswhen detecting the TVM-FFI environment streamFixes #3444.
Root cause
TVMFFIFunctionBuilder.find_env_stream()only inspected top-level parameters. When every GPU tensor was contained by aspec.TupleParam, the search returnedNoneand wrapper construction raisedEnvStream cannot be detectedeven though the parameter tree contained GPU tensors.Validation
Tested on an NVIDIA GeForce RTX 4070 Ti SUPER (SM89) against commit
564d267e4c.Base
The test failed during
cute.compile()with the expectedEnvStream cannot be detectederror.Patched
Neighboring tests
The local editable environment used the preparation-script change from #3417; that unrelated file is not included in this pull request.