[cho-m]

bottle :unneeded and bottle :disabled are invalid now so no need to audit these. Instead will be considered an invalid formula and fail to load.

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

n/a

---

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Bug Fixes
  • Formula audits no longer report a conflict when both bottle :modifier and a bottle do block are present. The documented audit checks have been updated accordingly. This changes which formulas receive an audit warning; it does not change how bottle settings are configured or used.

The ComponentsRedundancy cop no longer checks for a conflict between bottle :modifier and bottle do. The documentation and test for that check were also removed.

Changes: Bottle redundancy check

Layer / File(s)	Summary
Remove bottle modifier/block conflict check Library/Homebrew/rubocops/components_redundancy.rb, Library/Homebrew/test/rubocops/components_redundancy_spec.rb	The cop’s documented checks no longer include the bottle modifier/block conflict. The offense check and message were removed, along with the test that expected an offense.

Merge Risk: Minimal · up to b7947

No actionable issue has been identified that would prevent merging after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "rubocops/components_redundancy: drop bottle audit" matches the main change. The PR removes the ComponentsRedundancy check and its spec for the conflict between bottle :modifier and `bottl…
Description check		The description states that bottle :unneeded and bottle :disabled are now invalid, so auditing them is unnecessary, and that such formulae will fail to load. This relates directly to the removed a…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "rubocops/components_redundancy: drop bottle audit" matches the main change. The PR removes the ComponentsRedundancy check and its spec for the conflict between bottle :modifier and bottle do, along with the BOTTLE_MSG constant. The title names the file area and the removed audit, but it does not name the specific conflict being removed. It is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description states that bottle :unneeded and bottle :disabled are now invalid, so auditing them is unnecessary, and that such formulae will fail to load. This relates directly to the removed audit logic and spec in the changeset. The description also includes the standard checklist and an AI-usage disclosure. Those sections are template text, but the core explanation is on-topic.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b751de43-9d19-40bd-a9e2-889179560a41

Commits

Reviewing files that changed from the base of the PR and between 8b0b7e4 and b794704.

Files selected for processing: 2

• Library/Homebrew/rubocops/components_redundancy.rb
• Library/Homebrew/test/rubocops/components_redundancy_spec.rb

Files with no reviewable changes: 2

• Library/Homebrew/test/rubocops/components_redundancy_spec.rb
• Library/Homebrew/rubocops/components_redundancy.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[MikeMcQuaid]

Thanks!