Repository navigation
Don't report unchanged generated files as errors - #24431
Conversation
- `brew update-maintainers` and `brew generate-man-completions` exit non-zero when nothing changed so workflows can skip committing, but `ofail` also printed an error (a GitHub Actions error annotation in CI) for this expected outcome. - Print the message normally and keep the non-zero exit. Signed-off-by: Patrick Linnane <patrick@linnane.io>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Status output and failure state Library/Homebrew/dev-cmd/generate-man-completions.rb, Library/Homebrew/test/dev-cmd/generate-man-completions_spec.rb, Library/Homebrew/dev-cmd/update-maintainers.rb, Library/Homebrew/test/dev-cmd/update-maintainers_spec.rb |
GenerateManCompletions prints its status message and sets Homebrew.failed when the status is failure, unless --no-exit-code is specified. update-maintainers prints its no-changes message and sets Homebrew.failed when the README has no diff. Tests check the messages, stderr output, and failure state. |
Merge Risk: 
5740f
-
Expected no-change outcomes remain non-zero without error annotations. No merge-blocking issue was identified.
Pre-merge checks: 
-
Check name Status Explanation Title check The title states the main change: unchanged generated files no longer produce errors. The changeset replaces ofail with a normal message and sets Homebrew.failed for brew update-maintainers and brew g… Description check The description explains the change. It states that brew update-maintainers and brew generate-man-completions exit non-zero when nothing changed, that they used ofail (reported as a GitHub Actions err… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title states the main change: unchanged generated files no longer produce errors. The changeset replaces ofail with a normal message and sets Homebrew.failed for brew update-maintainers and brew generate-man-completions, so the title matches the core change.
Full details: Description check
-
Explanation
The description explains the change. It states that brew update-maintainers and brew generate-man-completions exit non-zero when nothing changed, that they used ofail (reported as a GitHub Actions error annotation), and that they now print the message normally while still exiting non-zero. This relates directly to the changeset.
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
brew update-maintainersandbrew generate-man-completionsexit non-zero when nothing changed so the sponsors, maintainers, manpage and completions workflow and the autogenerated files check can tell, but they usedofail, which reported that expected outcome as an error (a GitHub Actions error annotation in CI). They now print the message normally and still exit non-zero.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code (Opus 5.5) wrote the change and tests, checked that the new examples fail without the change and ran
brew lgtm.