Repository navigation
docs(contributing): list the exact SPDX license identifiers - #13
Merged
Merged
Conversation
The contributing guide listed the accepted licenses as "GPL-2.0 and 3.0, LGPL-2.1 and 3.0", whereas the catalog check only accepts exact SPDX identifiers with the `-only` or `-or-later` suffix: an entry with `license: GPL-3.0` is rejected. - List the identifiers of `ALLOWED_LICENSES` exactly - State that a wheel may combine them with `AND` and `OR`, whereas a module declares a single identifier Closes #12 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Summary
CONTRIBUTING.mdlisted the accepted licenses as "GPL-2.0 and 3.0, LGPL-2.1 and 3.0", whereas the catalog check (tools/catalog.py,ALLOWED_LICENSES) only accepts exact SPDX identifiers with the-onlyor-or-latersuffix: an entry withlicense: GPL-3.0is rejected.Changes
ANDandOR(License-Expression), whereas a module declares a single identifier.Validation
ALLOWED_LICENSES,_check_license(wheels) and the module check oftools/catalog.py.Found during a review of the DataLab Platform documentation (DataLab-Platform/DataLab#519).
Assisted-by: Claude Opus 5.5