Repository navigation
docs(i18n): restore icons in translated card titles - #555
Merged
Merged
Conversation
French card translations replaced the whole title, including the SVG generated by sphinx-design. Keep the original octicon role in translated titles so Sphinx regenerates the icon without displaying escaped SVG. - Restore 35 translated titles across six documentation catalogs - Correct the translation convention and preserve untranslated entries - Compare English and French card SVGs in documentation CI - Add the 1.4.1 release note and its French translation Closes #536 Assisted-by: GPT-6.1 Sol
sphinx-design 0.8 no longer includes SVG in gettext keys, so card titles can collide with plain-text translations and lose their icons even when the SVG-based translations are fixed for 0.7. - Use shared reST substitutions in all 41 icon-bearing card titles - Migrate catalog keys and preserve substitution delimiters in translations - Validate identical gettext keys and card SVGs with versions 0.7 and 0.8 Closes #536 Assisted-by: GPT-6.1 Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #536
Summary
French translations replaced the entire card title, including its icon. sphinx-design 0.7 extracts generated SVG in gettext keys, whereas 0.8 excludes icons and can reuse unrelated plain-text translations. Shared reST substitutions now give both versions identical, icon-specific keys. Translated cards retain the same icons as English cards without changes to the Sphinx engine or dependency requirements.
Changes
|card-icon-NAME|substitutions, defined indoc/_card_icons.txtand included by those pages.msgstr.doc/check_card_icons.pyand run it after both HTML builds in documentation CI. It compares title counts and complete SVG markup, and fails explicitly on missing or changed icons.Validation
contributing/index.html: card title 1 has missing or changed icons (English: 1, French: 0); exit code 1.-E -Wunder both sphinx-design 0.7.0 and an isolated 0.8.0 installation. Translation compilation passes.Out of scope
None. No application behavior, dependency requirements or release publication changes.
Assisted-by: GPT-6.1 Sol