[Postgres] Collect column statistics by default by sangeetashivaji · Pull Request #26015 · DataDog/integrations-core

sangeetashivaji · 2026-11-12T16:12:05Z

What does this PR do?

Turns on column statistics collection by default (collect_column_statistics.enabled: true). It still requires dbm: true.
Checks that the datadog.column_statistics() function exists before calling it. Databases without it are skipped with the existing one-time warning and health event, and no failing query appears in the Postgres logs.
Adds collect_column_statistics.function to use a function in a different schema, like query_samples.explain_function. Invalid names are rejected when the config loads.

Motivation

Column statistics help Database Monitoring reason about query plans, but as an opt-in setting they are rarely enabled. With this change, creating the function is the only setup step.

Checklist before requesting review

I self-reviewed the full diff, and this description matches the final change
Tests cover the change, or this description explains why none are needed
- An integration test runs a DBM instance with no column stats config and checks that column statistics are sent. Unit tests cover the existence check, the configurable function and name validation. Diagnose tests that check other features now turn column stats off explicitly.
Automated review comments, including Codex review, were addressed or answered
- Codex: the default flip is a changed entry (it changes emitted data for existing instances), and the new option is added. The default-on test now checks emitted events.
I, the human author, understand this change, can explain it to reviewers, and believe it meets the repository standards

🤖 Generated with Claude Code

collect_column_statistics.enabled now defaults to true, so every DBM Postgres instance collects pg_stats summaries without extra config. As an opt-in setting it was rarely enabled. Collection still needs the datadog.column_statistics() function in each database. Before reading it, the collector now checks for the function with to_regprocedure. A database without it is skipped with the same one-time warning and column_statistics_function_not_found health event as before, but without running a failing query, so instances that never set the function up don't get an hourly ERROR in their Postgres logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-11-12T16:13:01Z

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

dd-octo-sts · 2026-11-12T16:13:54Z

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

38/38 jobs

✅ 38 passed · nothing failed

Batches · ✅ batch-01 38/38

_{Dispatcher finished on cb282ce — GitHub Run · Dispatcher Logs.}

cit-pr-commenter-54b7da · 2026-11-12T16:14:24Z

evalya-impact-summary

Evalya CI impact

Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   4 (always emitted)
Changed files:   15

Full impact report
Learn more about CI impact filtering

datadog-datadog-prod-us1-2 · 2026-11-12T16:16:09Z

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry

🎯 Code Coverage (details)
• Patch Coverage: 98.10%
• Overall Coverage: 94.56% (+4.79%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 0fedf0e | Docs | View more details | Give us feedback!}

dd-octo-sts · 2026-11-12T16:21:36Z

Disk usage change

Commit 0fedf0e compared against cb282ce.

Uncompressed

linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB

Details

Name	Version	Type	linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
postgres	23.15.0	Integration	🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB	🔺 +2.29 KiB

Compressed

linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
🔺 +533 B	🔺 +533 B	🔺 +533 B	🔺 +533 B	🔺 +533 B

Details

Name	Version	Type	linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
postgres	23.15.0	Integration	🔺 +533 B	🔺 +533 B	🔺 +533 B	🔺 +533 B	🔺 +533 B

Adds collect_column_statistics.function (default datadog.column_statistics), matching query_samples.explain_function, so the function can live in another schema. The name is validated when the config loads: a function name of letters, digits and underscores, optionally schema-qualified, with an optional trailing "()". Anything else is a configuration error. It is quoted before it reaches SQL. The collector, the existence check, agent diagnose, the warning logs and the remediation text all use the configured name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-11-12T17:29:38Z

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-12T17:31:29.956734Z	`fb0e4bc`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb0e4bcdd2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-11-12T17:31:27Z

@@ -0,0 +1 @@
+Collect column statistics by default, and add the `collect_column_statistics.function` option to override the function used to read them.


Classify the default-on behavior as a breaking change

Rename this entry to 26015.changed: changing collect_column_statistics.enabled from false to true causes existing DBM instances to start emitting column-statistics data without a configuration change, which is exactly the repository's stated case for a backward-incompatible .changed entry. Leaving this as .added produces a minor release instead of the required major version bump.

AGENTS.md reference: AGENTS.md:L240-L244

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-11-12T17:31:27Z

+    assert check._config.collect_column_statistics.enabled
+    assert check.metadata_samples._column_statistics_collector is not None


Verify the observable default-on collection behavior

Replace these private-state assertions with a boundary-level assertion that omitting collect_column_statistics actually executes collection or emits a column-statistics event. This test still passes if the collector is constructed but never scheduled or run, so it does not protect the user-visible behavior claimed by the change and duplicates the configuration-default coverage.

AGENTS.md reference: AGENTS.md:L197-L205

Useful? React with 👍 / 👎.

datadog-datadog-prod-us1-2

More details

No reportable defect was found in the missing-function skip path or configurable function handling. Confidence is limited to static review and unit-level validation; live PostgreSQL integration behavior remains unverified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit fb0e4bc}

…est it end to end Default-on collection changes emitted data for existing DBM instances, which AGENTS.md classes as a changed entry, so the default flip is 26015.changed and the new function option is 26015.added. The default-on test now runs the check with no collect_column_statistics section and asserts column statistics events are emitted, instead of checking the collector object. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

dd-octo-sts · 2026-11-12T17:40:10Z

Validation Report

All 22 validations passed.

Show details

Validation	Description	Status
`agent-reqs`	Verify check versions match the Agent requirements file	✅
`ci`	Validate CI configuration and code coverage settings	✅
`codeowners`	Validate every integration has a CODEOWNERS entry	✅
`config`	Validate default configuration files against spec.yaml	✅
`dep`	Verify dependency pins are consistent and Agent-compatible	✅
`http`	Validate integrations use the HTTP wrapper correctly	✅
`imports`	Validate check imports do not use deprecated modules	✅
`integration-style`	Validate check code style conventions	✅
`jmx-metrics`	Validate JMX metrics definition files and config	✅
`labeler`	Validate PR labeler config matches integration directories	✅
`legacy-signature`	Validate no integration uses the legacy Agent check signature	✅
`license-headers`	Validate Python files have proper license headers	✅
`licenses`	Validate third-party license attribution list	✅
`metadata`	Validate metadata.csv metric definitions	✅
`models`	Validate configuration data models match spec.yaml	✅
`openmetrics`	Validate OpenMetrics integrations disable the metric limit	✅
`package`	Validate Python package metadata, naming, and wheel contents	✅
`pr-description`	Validate the pull request checklist and visible description length	✅
`qa-label`	Validate the pull request declares whether it needs QA for the next Agent release	✅
`readmes`	Validate README files have required sections	✅
`saved-views`	Validate saved view JSON file structure and fields	✅
`version`	Validate version consistency between package and changelog	✅

View full run

temporal-github-worker-1 Bot added agent/review-requested ecosystems/review-requested product/review-requested labels Nov 12, 2026

dd-octo-sts Bot added documentation integration/postgres internal Identify a non-fork PR labels Nov 12, 2026

Add changelog entry

0fc0910

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

sangeetashivaji and others added 2 commits November 12, 2026 11:36

Use an added changelog entry instead of changed

fb0e4bc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

sangeetashivaji added the qa/required QA is required for this PR and will generate a QA card label Nov 12, 2026

sangeetashivaji marked this pull request as ready for review November 12, 2026 17:29

sangeetashivaji requested review from a team as code owners November 12, 2026 17:29

dd-octo-sts Bot added team/agent-integrations team/database-monitoring-agent labels Nov 12, 2026

chatgpt-codex-connector Bot reviewed Nov 12, 2026

View reviewed changes

datadog-datadog-prod-us1-2 Bot reviewed Nov 12, 2026

View reviewed changes

		@@ -0,0 +1 @@
		Collect column statistics by default, and add the `collect_column_statistics.function` option to override the function used to read them.

		assert check._config.collect_column_statistics.enabled
		assert check.metadata_samples._column_statistics_collector is not None

Conversation

sangeetashivaji commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Checklist before requesting review

Uh oh!

github-actions Bot commented Nov 12, 2026

Uh oh!

dd-octo-sts Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Dispatcher tests: passed

Uh oh!

cit-pr-commenter-54b7da Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

evalya-impact-summary

Evalya CI impact

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Disk usage change

Uncompressed

Compressed

Uh oh!

chatgpt-codex-connector Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

sangeetashivaji Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

sangeetashivaji Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Nov 12, 2026

Validation Report

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sangeetashivaji commented Nov 12, 2026 •

edited

Loading

dd-octo-sts Bot commented Nov 12, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Nov 12, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Nov 12, 2026 •

edited

Loading

dd-octo-sts Bot commented Nov 12, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 12, 2026 •

edited

Loading