Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ Dispatcher tests: passed
✅ 50 passed · nothing failed Batches · ✅ batch-01 50/50 Dispatcher finished on |
evalya-impact-summaryEvalya CI impact |
There was a problem hiding this comment.
More details
The DBM labels match the collector’s configuration gate. Exactly 23 metric descriptions change, with all other CSV fields preserved; the specialist reported no actionable findings.
🤖 Bits Code Review · Commit ea4d6e0
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: e99116a | Docs | View more details | Give us feedback! |
ea4d6e0 to
8a9365f
Compare
There was a problem hiding this comment.
More details
The 23 query-metric descriptions consistently identify their DBM requirement while preserving metric names, types, units, and other CSV fields. The completed static review found no actionable defects.
🤖 Bits Code Review · Commit 8a9365f
There was a problem hiding this comment.
The PR labels 23 MongoDB query metrics as DBM-only and adds version/platform requirements, with planning time now documented from MongoDB 8.3. One documentation defect remains: 13 descriptions incorrectly apply the self-hosted MongoDB 8.0 minimum to Atlas deployments despite existing Atlas 7.0+ support; no earlier findings required resolution.
🤖 Bits Code Review · Commit f5fbff7
There was a problem hiding this comment.
More details
The PR marks 23 MongoDB query metrics as DBM-only and documents CPU-time, planning-time, and peak-memory availability. Removing all 13 universal MongoDB 8.0 prerequisites resolves the Atlas 7.x documentation defect; no findings remain open, and metric definitions and runtime behavior are unchanged.
🤖 Bits Code Review · Commit 00df272
The public MongoDB metrics page is generated from mongo/metadata.csv. The mongodb.queries.* metrics were listed with no indication that they require Database Monitoring, so customers running the plain integration expect them and open tickets when they never appear. Label all 23 with (DBM only), matching the Postgres/MySQL/SQL Server wording. The check never emits these directly; they derive from the DBM query-metrics job, dispatched only under 'if self._config.dbm_enabled:'. mongodb.usage.queries.* is left alone because the standard top collector emits it without DBM. Three metrics also get a note because the MongoDB server does not report the underlying $queryStats field until a given version, so they stay absent even with DBM enabled. Each was reproduced against a real mongod: cpuNanos absent on 8.0.34 and present on 8.2.12 (Linux only, per MongoDB's docs), planningTimeMicros absent on 8.2.12 and present on 8.3.13, and both peak-memory fields first appearing on 9.0.4. The 7.0-Atlas / 8.0-self-hosted $queryStats minimum is deliberately not repeated here. It is an Agent collection gate rather than a per-metric property, and is already documented with both halves in mongo/assets/configuration/spec.yaml. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
00df272 to
e99116a
Compare
Validation ReportAll 22 validations passed. Show details
|
There was a problem hiding this comment.
More details
The DBM-only labels align with the collector’s enablement gate. The MongoDB version and Linux availability notes rely on the author’s reported server checks and were not independently reproduced.
🤖 Bits Code Review · Commit e99116a
What does this PR do?
Labels all 23
mongodb.queries.*metrics inmongo/metadata.csvwith(DBM only), matching the Postgres/MySQL/SQL Server wording. Two metrics also gain a MongoDB version note, andcpu_timea platform note. Descriptions only, no behaviour change.ddev validate metadata mongopasses.Motivation
The public MongoDB metrics page is generated from this file. Today
mongodb.queries.*is listed with no sign that it needs Database Monitoring, so customers on the plain integration expect these metrics and file tickets when they never appear.The check never emits
mongodb.queries.*directly; they derive from the DBM query-metrics job (mongo/datadog_checks/mongo/dbm/query_metrics.py), dispatched only underif self._config.dbm_enabled:.mongodb.usage.queries.*is untouched: the standardtopcollector emits it without DBM.The three version/platform notes cover metrics that are absent even with DBM on, because the MongoDB server does not report the underlying
$queryStatsfield yet:cpu_time(cpuNanos) — MongoDB 8.2, Linux onlyplanning_time(planningTimeMicros) — MongoDB 8.3peak_memory_usage/cluster_peak_memory_usage— MongoDB 9.0Verification
Each was reproduced against real
mongodcontainers (6.0.28, 7.0, 8.0.34, 8.2.12, 8.3.13, 9.0.4), probing$queryStatswith the samecursor/queryExec/queryPlanner/writesflattening_normalize_rowsapplies.cpuNanosis absent on 8.0.34 and present on 8.2.12;planningTimeMicrosabsent on 8.2.12, present on 8.3.13; both peak-memory fields first appear on 9.0.4.(DBM only)was verified end to end on 8.2.12 with the real check against a real server:dbm: falseemits 0 query-metrics payloads,dbm: trueemits payloads containingcpu_nanos_sumand the rest.The Linux restriction is MongoDB's own: "This document is only available on Linux systems. New in version 8.2" ($queryStats reference).
Deliberately not duplicated here: the
$queryStatsminimum of 7.0 on Atlas / 8.0 self-hosted. That is an Agent collection gate rather than a per-metric fact, and it is already documented with both halves inmongo/assets/configuration/spec.yaml.Checklist before requesting review