G
YouTube TikTok Games
Skip to content

deps: bump follow-redirects from 1.16.1 to 1.16.3 - #126

Merged
tomasr78 merged 1 commit into
mainfrom
deps-follow-redirects
Nov 9, 2026
Merged

tomasr78 merged 1 commit into
mainfrom
deps-follow-redirects

Conversation

@tomasr78

@tomasr78 tomasr78 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Problem

The build job runs npm audit --omit=dev --audit-level=high, and it has failed on main since 2026-11-07: https://github.com/ConvertAPI/convertapi-library-node/actions/runs/42359841164 (push of a402bd7; the three test jobs passed, only "Audit the runtime dependencies" failed).

axios requires follow-redirects ^1.16.0, and package-lock.json resolves it to 1.16.1, which has the high-severity advisory GHSA-mrwp-f3q8-3g9p (affects 1.16.0 - 1.16.1, fixed in 1.16.2). publish.yml runs the same audit, so no release can go out until this is fixed. It is also the only failing check on #123 and fails #124.

Change

npm update follow-redirects --ignore-scripts (Node v24.20.0, npm 11.19.0) moves the lockfile entry from 1.16.1 to 1.16.3, the latest release. The diff is that entry's version, resolved and integrity, nothing else; package.json is unchanged.

package-lock.json is not part of the npm package, and consumers resolve follow-redirects themselves (axios asks for ^1.16.0, so a fresh install gets 1.16.3), so there is no CHANGELOG entry.

Verification

After npm ci --ignore-scripts on main (a402bd7):

$ npm audit --omit=dev --audit-level=high        # main: exit code 1
# npm audit report

follow-redirects  1.16.0 - 1.16.1
Severity: high
follow-redirects: Cross-realm sensitiveHeaders arrays are discarded and custom credentials can follow redirects - https://github.com/advisories/GHSA-mrwp-f3q8-3g9p
fix available via `npm audit fix`
node_modules/follow-redirects

1 high severity vulnerability

To address all issues, run:
  npm audit fix

After npm ci --ignore-scripts on this branch:

$ npm audit --omit=dev --audit-level=high        # this branch: exit code 0
found 0 vulnerabilities
  • npm run build passes.
  • npm test (lint, then the tests against staging with CONVERT_API_BASE_URI=https://stag-v2.convertapi.com/): 16 passing.
  • npm audit signatures: all 696 packages have verified registry signatures.
  • 1.16.3 was published on 2026-11-08. Its index.js, debug.js, http.js and https.js are identical to the v1.16.3 tag of https://github.com/follow-redirects/follow-redirects. From 1.16.1 to 1.16.3, index.js changes in two places: Array.isArray for sensitiveHeaders (the advisory fix, 1.16.2) and braces escaped in escapeRegex (1.16.3), see follow-redirects/follow-redirects@v1.16.1...v1.16.3

After merging

🤖 Generated with Claude Code

follow-redirects 1.16.0 - 1.16.1 has the high-severity advisory
GHSA-mrwp-f3q8-3g9p, fixed in 1.16.2.
axios requires follow-redirects ^1.16.0 and the lockfile resolved it
to 1.16.1, so `npm audit --omit=dev --audit-level=high` in the build
job has failed on main since 2026-11-07. `npm update follow-redirects`
moves only this entry, to 1.16.3, the latest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomasr78 tomasr78 added the dependencies Pull requests that update a dependency file label Nov 9, 2026
Copilot AI balanced review requested due to automatic review settings November 9, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@tomasr78
tomasr78 merged commit 9551e38 into main Nov 9, 2026
4 checks passed
@tomasr78
tomasr78 deleted the deps-follow-redirects branch November 9, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants