Repository navigation
deps: bump follow-redirects from 1.16.1 to 1.16.3 - #126
Merged
Merged
Conversation
follow-redirects 1.16.0 - 1.16.1 has the high-severity advisory GHSA-mrwp-f3q8-3g9p, fixed in 1.16.2. axios requires follow-redirects ^1.16.0 and the lockfile resolved it to 1.16.1, so `npm audit --omit=dev --audit-level=high` in the build job has failed on main since 2026-11-07. `npm update follow-redirects` moves only this entry, to 1.16.3, the latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
buildjob runsnpm audit --omit=dev --audit-level=high, and it has failed onmainsince 2026-11-07: https://github.com/ConvertAPI/convertapi-library-node/actions/runs/42359841164 (push of a402bd7; the three test jobs passed, only "Audit the runtime dependencies" failed).axios requires
follow-redirects ^1.16.0, andpackage-lock.jsonresolves it to 1.16.1, which has the high-severity advisory GHSA-mrwp-f3q8-3g9p (affects 1.16.0 - 1.16.1, fixed in 1.16.2).publish.ymlruns the same audit, so no release can go out until this is fixed. It is also the only failing check on #123 and fails #124.Change
npm update follow-redirects --ignore-scripts(Node v24.20.0, npm 11.19.0) moves the lockfile entry from 1.16.1 to 1.16.3, the latest release. The diff is that entry'sversion,resolvedandintegrity, nothing else;package.jsonis unchanged.package-lock.jsonis not part of the npm package, and consumers resolve follow-redirects themselves (axios asks for^1.16.0, so a fresh install gets 1.16.3), so there is no CHANGELOG entry.Verification
After
npm ci --ignore-scriptsonmain(a402bd7):After
npm ci --ignore-scriptson this branch:npm run buildpasses.npm test(lint, then the tests against staging withCONVERT_API_BASE_URI=https://stag-v2.convertapi.com/): 16 passing.npm audit signatures: all 696 packages have verified registry signatures.index.js,debug.js,http.jsandhttps.jsare identical to thev1.16.3tag of https://github.com/follow-redirects/follow-redirects. From 1.16.1 to 1.16.3,index.jschanges in two places:Array.isArrayforsensitiveHeaders(the advisory fix, 1.16.2) and braces escaped inescapeRegex(1.16.3), see follow-redirects/follow-redirects@v1.16.1...v1.16.3After merging
gh pr update-branch 123 --repo ConvertAPI/convertapi-library-node. Re-running its old run would reuse the old merge commit, which still has 1.16.1.@dependabot rebaseon it.🤖 Generated with Claude Code