G
YouTube TikTok Games
Skip to content

Add paired Human Design Review Brief to design workflow - Fixes AB#3822787 - #495

Open
moumighosh wants to merge 1 commit into
masterfrom
moumighosh-human-design-review-brief
Open

moumighosh wants to merge 1 commit into
masterfrom
moumighosh-human-design-review-brief

Conversation

@moumighosh

@moumighosh moumighosh commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Fixes AB#3822787

Parent feature: Android Client Software Factory (3797944).

Summary

Follow-up to merged #492, created from master at 905396c467d14d9842d147de3992d1dcfb496d32. This is a new focused PR; it does not modify that PR or any nested Android checkout.

  • Generate a separate Human Design Review Brief in the existing author/revision calls. Make it the primary human approval surface while retaining the authoritative detailed design and supporting section/evidence links.
  • Put owned decisions first; cover outcomes and behavior/scope, plain-language architecture/flow, alternatives and tradeoffs, evidence versus assumptions, uncertainties, and all five consequential risk categories with substantive safeguards or justified N/A.
  • Enforce the complete rendered brief's 1,800-word / 16,000-JavaScript-character budget. Never truncate or silently omit approval-critical content. Copy authoritative baseline/deltas, assumptions, unknowns and open decisions visibly.
  • Require independent consistency/completeness/risk/evidence/change checks and the exact pair revision. Generate both linked Markdown documents together with revision and UTF-8 byte SHA-256 hashes; provide a deterministic publication-integrity verifier.
  • Advance checkpoint compatibility to v11 so legacy unpaired output cannot bypass the contract. Verify prior human-review snapshots/provenance and highlight changes; fresh human approval remains pending for every pair.
  • Update local, root-skill and shipped-plugin guidance. Preserve evidence pins/digests, existing seven-agent/one-concurrent/1,800-second/20-credit limits, accessibility/default-off gates, separate telemetry/query/release boundaries and post-implementation pre-mortem timing. Design approval is not rollout permission.

Validation

  • node --test .github\extensions\DevDesignDoc\workflow.test.mjs: 64 passed; 0 failed, skipped or cancelled (baseline: 53 tests). Covers malformed/bounded briefs, hidden or contradictory risks, stale reviews and prior snapshots, revised pairs, exact-byte publication integrity, same-revision links/hashes, v10 rejection/v11 replay and retained existing gates.
  • node --check .github\extensions\DevDesignDoc\workflow.mjs: passed.
  • node --check .github\extensions\DevDesignDoc\workflow.test.mjs: passed.
  • node --check .github\extensions\DevDesignDoc\extension.mjs: passed.
  • Read-only documentation coherence check: 6 local links/anchors passed across the three changed guidance files.
  • git diff --check: passed. Extension reload reports DevDesignDoc ready.

Limitations and merge prerequisites

The workflow returns both publication-ready documents in one packet; it does not introduce an external publisher. Callers must durably publish both unchanged together and verify the read-back manifest. Regression tests mock independent-agent judgments; no paid design workflow or live model-quality evaluation was run. No Android code changed or Android validation was needed.

Tracking PBI 3822787 is Committed under Feature 3797944. The required AB linkage check must pass for the updated PR; one approving human review is also required. No policy/skip-label bypass is attempted, and no PR merge or rollout approval is requested.

Generate the primary human decision surface alongside the authoritative design, verify completeness and consistency in existing review rounds, and bind paired publication to exact reviewed revisions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@moumighosh
moumighosh requested a review from a team as a code owner November 14, 2026 00:53
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown

❌ Invalid work item number: AB#ID. Work item number must be a valid integer.

Click here to learn more.

@moumighosh moumighosh changed the title Add paired Human Design Review Brief to design workflow Add paired Human Design Review Brief to design workflow - Fixes AB#3822787 Nov 14, 2026
@github-actions

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3822787 to an Azure Boards work item.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant