Repository navigation
fix(security): charge pop filter allocation to memoryLimit - #907
Merged
Merged
Conversation
The `pop` array filter cloned the input via `[...toArray(v)]` without charging `this.context.memoryLimit.use(...)`, bypassing the memoryLimit DoS guard that its sibling filters (shift, unshift, compact, etc.) apply. Mirror `shift` to account for the O(N) allocation. Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 27492309498Coverage remained the same at 99.543%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
…mit (CWE-770) Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
## [10.27.1](v10.27.0...v10.27.1) (2026-06-23) ### Bug Fixes * improve round function; improvement to [#873](#873) ([#901](#901)) ([956b51e](956b51e)) * **security:** charge pop filter allocation to memoryLimit ([#907](#907)) ([8a0c74a](8a0c74a)) * **strip_html:** infinite loop for strip_html ([5c3522f](5c3522f)) ### Performance Improvements * **parser:** memoize createTrie to avoid rebuilding tries per Tokenizer ([#911](#911)) ([3a0d80d](3a0d80d))
|
🎉 This PR is included in version 10.27.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
poparray filter cloned the input via[...toArray(v)]without chargingthis.context.memoryLimit.use(...), bypassing the memoryLimit DoS guard that its sibling filters (shift, unshift, compact, etc.) apply. Mirrorshiftto account for the O(N) allocation.